Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to 1.10 #27

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Upgrade Go to 1.10 #27

merged 1 commit into from
Feb 26, 2018

Conversation

ifraixedes
Copy link
Contributor

Upgrade the Go version to use the last stable release, the 1.10.

https://blog.golang.org/go1.10

@xescugc
Copy link
Member

xescugc commented Feb 19, 2018

Something is wrong with the CI:

$ go version
go version go1.1 linux/amd64

This issue is tracked on: travis-ci/gimme#132

@ifraixedes
Copy link
Contributor Author

We'll wait for it.

@xescugc
Copy link
Member

xescugc commented Feb 19, 2018

We could potentially use the 1.10.x

@xlr-8
Copy link
Contributor

xlr-8 commented Feb 26, 2018

Apparently this was closed: travis-ci/gimme#132 (comment)

@ifraixedes
Copy link
Contributor Author

I relaunch the CI from the travis interface, but the same problem raised :|

I'm going to repush it and see if that can change something in the next build that isn't applied doing the relaunch from the UI.

@ifraixedes
Copy link
Contributor Author

It's still failing.

I've never setup travis, so I'm not very experienced with it and I don't know how it was setup here.

I see that the issue is related to something called gimme, @xlr-8 are we using that think for the travis configuration of this project or it's something that's used when Go is configured?

@xlr-8
Copy link
Contributor

xlr-8 commented Feb 26, 2018

According to the issue, it's because "1.10" has to be used - with the quotes, not alone, see commits/comments after the issue had been closed.

@ifraixedes
Copy link
Contributor Author

oh my god, but that has been always there; it has been better to tell me directly to wrap the version in quotes than pointing to the issue, I totally missed the part of wrapping it.

@xlr-8 thanks!

@xlr-8
Copy link
Contributor

xlr-8 commented Feb 26, 2018

sorry, we'll do next time!

Upgrade the Go version to use the last stable release, the 1.10.

https://blog.golang.org/go1.10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.473% when pulling 79b8285 on if-upgrade-go-1.10 into 53ad9e7 on master.

@ifraixedes ifraixedes merged commit e6b7dd7 into master Feb 26, 2018
@ifraixedes ifraixedes deleted the if-upgrade-go-1.10 branch February 26, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants