Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoscaling: add ASG LC LT #52

Merged
merged 1 commit into from
Nov 27, 2019
Merged

autoscaling: add ASG LC LT #52

merged 1 commit into from
Nov 27, 2019

Conversation

talset
Copy link
Member

@talset talset commented Nov 26, 2019

Add LaunchConfiguration/template List function
Add Autoscaling List function

@talset talset changed the title autoscaling: add ASG LC LT autoscaling: add ASG LC LT [in progress] Nov 26, 2019
@xescugc
Copy link
Member

xescugc commented Nov 26, 2019

LGTM but you need to order the imports, check the CI.

@talset
Copy link
Member Author

talset commented Nov 26, 2019

LGTM but you need to order the imports, check the CI.

Sure Will do it.

I only validated LC with terracognita. I will wait to validate the autoscaling/LT too before to merge

@talset talset changed the title autoscaling: add ASG LC LT [in progress] autoscaling: add ASG LC LT Nov 26, 2019
@talset
autoscaling ASG LC LT
b29684f 
Add LaunchConfiguration/template List function
Add Autoscaling List function
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.124% when pulling b29684f on fl-asg into 504d971 on master.

xescugc
xescugc approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@xescugc xescugc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@talset talset merged commit 28cf2f6 into master Nov 27, 2019
@talset talset deleted the fl-asg branch November 27, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xescugc xescugc xescugc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talset @xescugc @coveralls