connector: customendpoint for NewAWSReader #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talset
changed the title
xescugc
requested changes
May 4, 2020
xescugc
requested changes
May 4, 2020
connector.go
Outdated
| @@ -53,17 +53,32 @@ func NewAWSReader( | |||
| ctx context.Context, accessKey string, secretKey string, regions []string, config *aws.Config, | |||
| ) (AWSReader, error) { | |||
| var c = connector{} | |||
| const customEndpointRegion string = "custom" | |||
There was a problem hiding this comment.
I meant to have a raws.CustomRegion basically, so it's something anyone using the lib can use to flag that instead of using a direct "custom" which is "worse".
talset
changed the title
talset
force-pushed
the
fl-minio
branch
2 times, most recently
from
5b36a45
to
c6bbcb1
Compare
xescugc
requested changes
May 6, 2020
| @@ -50,20 +50,25 @@ import ( | |||
| // * https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html#CommonErrors | |||
| // * https://docs.aws.amazon.com/STS/latest/APIReference/CommonErrors.html | |||
| func NewAWSReader( | |||
| ctx context.Context, accessKey string, secretKey string, regions []string, config *aws.Config, | |||
| ) (AWSReader, error) { | |||
| ctx context.Context, accessKey string, secretKey string, regions []string, config *aws.Config, customEndpoint bool) (AWSReader, error) { | |||
There was a problem hiding this comment.
Document on this method what the customEndpoint is on the params
xescugc
reviewed
May 7, 2020
| @@ -50,20 +50,25 @@ import ( | |||
| // * https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html#CommonErrors | |||
| // * https://docs.aws.amazon.com/STS/latest/APIReference/CommonErrors.html | |||
| func NewAWSReader( | |||
| ctx context.Context, accessKey string, secretKey string, regions []string, config *aws.Config, | |||
| ) (AWSReader, error) { | |||
| ctx context.Context, accessKey string, secretKey string, regions []string, config *aws.Config, customEndpoint bool) (AWSReader, error) { | |||
There was a problem hiding this comment.
So goo docs but I want them also on the function description of NewAWSReader hehe
Workaround to use min.io or other compatible service as s3 backend Set customEndpoint = true to indicate that we are not using aws services.
xescugc
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to use min.io or other compatible service as s3 backend
Set customEndpoint = true to indicate that we are not using aws services.