Fixed: Error with the Import Filter not validating before Importing/Reading #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To validate if the Provider supports that specific Resource Type
…ovider' interface
xlr-8
suggested changes
Jun 20, 2019
errcode/codes.go
Outdated
| @@ -4,6 +4,7 @@ import "errors" | |||
|
|
|||
| // List of all the error Codes used | |||
| var ( | |||
| ErrProviderResourceNotSupported = errors.New("the resource type it's not supported") | |||
provider/import_test.go
Outdated
| @@ -300,4 +304,27 @@ func TestImport(t *testing.T) { | |||
| err := provider.Import(ctx, p, hw, sw, f) | |||
| require.NoError(t, err) | |||
| }) | |||
| t.Run("ErrorWithIncorrectFiler", func(t *testing.T) { | |||
xlr-8
approved these changes
Jun 20, 2019
…to fetch them This way if some of the resources are not valid it'll just fail before start fetching the resources and fail without importing anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an error when
-ihad a wrong resource, it would start importing anyway and then crash when trying to import this resource. Now a check prior importing is done to ensure resources are all valid