Changed: Backend is now on it's own package #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing a 'go run' to a repository we directly use the binary. Also did the same on the Makefile
And renamed the functions to the plural form as those are collections of elements
Instead of true|false use a named variable so it eases the readability of the code
xescugc
force-pushed
the
fg-refactors
branch
from
056d76b
to
6df904c
Compare
xescugc
force-pushed
the
fg-refactors
branch
from
6df904c
to
eb71a4f
Compare
Even if it's the same better use the stdlib definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was repeated in
cost.Backendandterracost.Backendso it's now abstracted to it's own package and used instead of redeclared.Also did some minor fixes but the main one would be the
//go:generatefunctions that where usinggo run {pkg}instead of the binary alone, which was not working and it's not how it's suppose to be used either. Also did the same no the Makefile removing all thego runand just used the binary of the lib.