-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📣 v2 finalization #158
Comments
I know you were waiting for this for a long time, @llaville :D |
Yes, and of course I'll test it, but I'm not sure to have time this week-end. |
released preview: v2.0.0-RC1 |
👁️🗨️ I'll have a quick try with migration on my project tomorrow morning ! |
❤️ |
@jkowalleck I've just finished to migrate code from v1 to v2, and here are my first feedbacks. Even, if my code (see my migration with commit llaville/box-manifest@e4a4058) is not so complex (I hope ;-)), it took me half an hour between change code from old format to newer, and test it to see if there are some regressions. I think you should write a migration guide that will make the developers task more easy ! If you've time to check my commit and tell me if I'm wrong or not in my code migration. I've tested spec 1.3 because I've a base results to compare, but spec 1.4 is pretty for me now to implement on my application (but I've no base to compare), so no feeback for this results. |
@jkowalleck I've just tested spec 1.4 in my application (code of box-manifest) will be pushed to GitHub tomorrow (I'll be busy this afternoon and won't be online for hours), and see no regression with spec 1.3 ! Good news :) Last but not least: results I produced (using spec 1.3 or spec 1.4) can be validate with https://github.com/CycloneDX/cyclonedx-cli#validate-command |
Thanks for testing.
Well, I might write a migration instruction for v2.0, then.
I had no doubt on the quality of my library, as I have more than 3400 tests to assert the correctness of the models and normalization/serialization, and I have a working validator as part of the implementation as well ;-) |
Mea Culpa, I didn't read the release notes, and I think it's enough. Perharps you may add a link on the project README page to learn more about how to migrate (to this release notes). BTW, thanks for your review on my code. I appreciate a lot !!! |
@jkowalleck By implementing support of all sbom spec version with my commit llaville/box-manifest@0ac39af on box-manifest app, I've used twice the tip provided at https://www.php.net/manual/en/language.enumerations.static-methods.php#126866 Does it make sense for you to implement such new method That will allow me to reduce my code :
Goal : support as much as possible future spec version without to change the base code |
I do not see a reason for this. PS: do not want to add `values(). Who knows, this might be added natively in the next version of PHP language level support for ENUMs. |
closed by #266 |
The text was updated successfully, but these errors were encountered: