Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused UI fields are visible over header #253

Closed
petar-cvit opened this issue May 5, 2024 · 4 comments · Fixed by #254
Closed

Focused UI fields are visible over header #253

petar-cvit opened this issue May 5, 2024 · 4 comments · Fixed by #254
Assignees
Labels
good first issue Good for newcomers react UI Update on the UI

Comments

@petar-cvit
Copy link
Collaborator

petar-cvit commented May 5, 2024

Describe the bug
When a field on the New Module / Edit Module is in focus, and you scroll down, the field in focus goes over the header.

reoproduce-field-focus-issue.mov

To Reproduce
Steps to reproduce the behavior:

  1. Install templates into your cluster
    kubectl apply -f https://raw.githubusercontent.com/cyclops-ui/cyclops/main/install/demo-templates.yaml
  2. Select the demo-extended template since its the longest template
  3. Expand nested fields as in the video above so you can scroll down.
  4. Select one field as if you would change it's value
  5. If you scroll down, you should see the field is over the header.

Expected behavior
Fields shouldn't go over the header.

Proposed solution
We can change the z-index of those components or set overflow: hidden

@petar-cvit petar-cvit added good first issue Good for newcomers UI Update on the UI react labels May 5, 2024
@AKHIL-DyC
Copy link
Contributor

can i work on this issue

@hanshal101
Copy link
Contributor

Go on @AKHIL-DyC !

AKHIL-DyC added a commit to AKHIL-DyC/cyclops that referenced this issue May 5, 2024
@AKHIL-DyC
Copy link
Contributor

#254

@hanshal101
Copy link
Contributor

Hey @AKHIL-DyC thanks for your contribution can you add the Issue tag on your PR description, something like this:

Fixes (#)253 (note dont add the bracket around the hash)

petar-cvit added a commit that referenced this issue May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers react UI Update on the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants