Feat :Add template flag to cyctl on module creation #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamrazorpay
changed the title
shivamrazorpay
changed the title
petar-cvit
requested changes
Jul 20, 2024
cyctl/internal/create/modules.go
Outdated
Comment on lines
91
to
93
| if (templateName != "" && (repo != "" || path != "")) || (templateName == "" && (repo == "" || path == "")) { | ||
| log.Fatalf("Error: Either template or (repo and path) must be provided.") | ||
| } |
There was a problem hiding this comment.
Can you also add version here?
Suggested change
| if (templateName != "" && (repo != "" || path != "")) || (templateName == "" && (repo == "" || path == "")) { | |
| log.Fatalf("Error: Either template or (repo and path) must be provided.") | |
| } | |
| if (templateName != "" && (repo != "" || path != "" || version != "")) || (templateName == "" && (repo == "" || path == "")) { | |
| log.Fatalf("Error: Either template or (repo, path and version) must be provided.") | |
| } |
There was a problem hiding this comment.
Version was not a compulsory flag that is why I left it. I have added it now.
There was a problem hiding this comment.
Makes sense @shivamrazorpay. This is just users dont use the --version flag to override the version in the template.
Can you push the update?
petar-cvit
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #
📑 Description
templateflag to cyctl on module creation #439✅ Checks
ℹ Additional context