Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render admin boundaries and refactor protected areas #309

Merged
merged 10 commits into from
Feb 23, 2020

Conversation

Florimondable
Copy link
Member

@Florimondable Florimondable commented Feb 14, 2020

to fix #209, copied from OSM.org carto style, grey, thinner, faded.
Only international borders are very important so they are rendered in large grey full line, the use of others is very low hence the fading for them, look for the grey thin dashed lines.

Capture du 2020-02-14 23-22-19
Capture du 2020-02-14 23-22-36
Capture du 2020-02-14 23-21-37
Capture du 2020-02-14 23-20-18
Capture du 2020-02-14 23-25-00
Capture du 2020-02-14 23-24-48
Capture du 2020-02-14 23-24-19

@Florimondable Florimondable changed the title Render admin boundaries Render admin boundaries and refactor protected areas Feb 16, 2020
@Florimondable
Copy link
Member Author

Refactor protected areas, to fix #37

Before:
Capture du 2020-02-16 18-13-50
Capture du 2020-02-16 18-13-36

After:
Capture du 2020-02-16 18-08-58
Capture du 2020-02-16 18-09-29
Capture du 2020-02-16 18-10-01
Capture du 2020-02-16 18-10-34
Capture du 2020-02-16 18-10-56

@Florimondable
Copy link
Member Author

Add names for every areas and make the area a little less dark :
Capture du 2020-02-17 23-42-49
Capture du 2020-02-17 23-43-34

@Florimondable
Copy link
Member Author

and the inner area background lining
Capture du 2020-02-17 23-46-21

@Florimondable
Copy link
Member Author

Capture du 2020-02-19 22-00-53

@Florimondable
Copy link
Member Author

Central America for international border examples :
Capture du 2020-02-20 19-21-44
Capture du 2020-02-20 19-14-40
Capture du 2020-02-20 19-16-19

@Florimondable
Copy link
Member Author

Florimondable commented Feb 20, 2020

Test perf : it seems that the rendering time increased of about 10% at all levels.

@Phyks Phyks merged commit 1132967 into cyclosm:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render administrative boundaries
2 participants