Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleWithProviders references need to use an explicit generic type in angular 9 #69

Closed
JeroMiya opened this issue Feb 13, 2020 · 1 comment · Fixed by #67
Closed

ModuleWithProviders references need to use an explicit generic type in angular 9 #69

JeroMiya opened this issue Feb 13, 2020 · 1 comment · Fixed by #67
Labels
bug Something isn't working

Comments

@JeroMiya
Copy link

JeroMiya commented Feb 13, 2020

In generated services, you'll see references to ModuleWithProvider without an explicit type. This is no longer allowed in angular9:

export class ApiModule {
  static forRoot(params: ApiConfigurationParams): ModuleWithProviders {
    return {
      ngModule: ApiModule,
// etc....

It should use an explicit generic type:

export class ApiModule {
  static forRoot(params: ApiConfigurationParams): ModuleWithProviders<ApiModule> {
    return {
      ngModule: ApiModule,

Looks like this is fixed in:
#67

@luisfpg
Copy link
Contributor

luisfpg commented Feb 14, 2020

Yes, @RGunning shared a PR for this.
I'm still in vacation, and will try to test and merge it next week.

@luisfpg luisfpg added the bug Something isn't working label Feb 14, 2020
luisfpg pushed a commit that referenced this issue Feb 19, 2020
* feat: angular v9 migrations

fixes for angular v9 compatibility

* Update templates/baseService.handlebars

Co-Authored-By: Jeremy <bell.jeremy@gmail.com>

Co-authored-by: Jeremy <bell.jeremy@gmail.com>

Fixes #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants