Skip to content

Commit

Permalink
Merge pull request #1537 from bam241/fix_conda
Browse files Browse the repository at this point in the history
Fix Conda install on MAC OS
  • Loading branch information
gonuke committed Jan 13, 2020
2 parents 1b60ab1 + aca809e commit 742bb9a
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ IF(NOT CYCLUS_DOC_ONLY)

# make sure we know about having python
add_definitions(-DCYCLUS_WITH_PYTHON)
set(LIBS ${LIBS} ${PYTHON_LIBRARIES})
IF (NOT APPLE)
set(LIBS ${LIBS} ${PYTHON_LIBRARIES})
ENDIF (NOT APPLE)
INCLUDE_DIRECTORIES("${CMAKE_CURRENT_BINARY_DIR}/cyclus")
else(Cython_FOUND)
# If we don't have Python bindings, we may try to find tcmalloc.
Expand Down
3 changes: 3 additions & 0 deletions cli/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ INCLUDE_DIRECTORIES(BEFORE ${CYCLUS_CORE_INCLUDE_DIRS})
SET(CYCLUS_SOURCE ${CYCLUS_SOURCE}
cyclus.cc
)
IF (APPLE)
SET(LIBS ${PYTHON_LIBRARIES} ${LIBS})
ENDIF(APPLE)

ADD_EXECUTABLE(cyclus_cli ${CYCLUS_SOURCE})
set_target_properties(cyclus_cli PROPERTIES OUTPUT_NAME cyclus)
Expand Down
6 changes: 5 additions & 1 deletion cyclus/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
try:
import concurrent_futures
except ImportError:
concurrent_futures = None
try:
from concurrent import futures as concurrent_futures
except ImportError:
concurrent_futures = None



15 changes: 15 additions & 0 deletions news/python_lib.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
**Added:** None

**Changed:**
- for MACOS only link against PYTHON lib in the binary building process. It
should not be required when building the Python package as python knows about
it self. For some reason, this is only true (and working) on MACOS, and was an issue when
using Conda to install Python and other CYclus deps.

**Deprecated:** None

**Removed:** None

**Fixed:** None

**Security:** None

0 comments on commit 742bb9a

Please sign in to comment.