Apply suggestions from code review

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu> Signed-off-by: Katie Mummah <katiemummah@gmail.com>
cyclus · Jun 13, 2024 · ede829a · ede829a
1 parent f2baa74
commit ede829a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/package.cc b/src/package.cc
@@ -87,7 +87,7 @@ TransportUnit::Ptr& TransportUnit::unrestricted() {
 
 int TransportUnit::GetTransportUnitFill(int qty) {
   if (qty < fill_min_) {
-    // less than one pkg of material available
+    // less than one TransportUnit of material available
     return 0;
   }
 

diff --git a/src/package.h b/src/package.h
@@ -9,7 +9,7 @@
 
 namespace cyclus {
 
-/// Packager is a class that packages materials into discrete items in ways 
+/// Package is a class that packages materials into discrete items in ways 
 // that mimic realistic nuclear material handling. Package is a parameter
 // of materials and products, with default unpackaged
 class Package {

diff --git a/src/toolkit/matl_sell_policy.cc b/src/toolkit/matl_sell_policy.cc
@@ -213,9 +213,7 @@ std::set<BidPortfolio<Material>::Ptr> MatlSellPolicy::GetMatlBids(
       int shippable_pkgs = transport_unit_->MaxShippablePackages(bids.size());
       if (shippable_pkgs < bids.size()) {
         // can't ship all bids. Pop the extras.
-        for (int i=0; i<(bids.size() - shippable_pkgs); i++) {
-          bids.pop_back();
-        }
+        bids.erase(bids.begin() + shippable_pkgs, bids.end())
       }
 
       // Peek at resbuf to get current composition