Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to check code style with clang-format #1669

Open
gonuke opened this issue Feb 14, 2024 · 2 comments
Open

Add workflow to check code style with clang-format #1669

gonuke opened this issue Feb 14, 2024 · 2 comments
Assignees
Labels
Style Updates in coding style without feature additions

Comments

@gonuke
Copy link
Member

gonuke commented Feb 14, 2024

To impose coding style we should check each PR with clang-format and include a style file. This is done now in svalinn/DAGMC

@ahnaf-tahmid-chowdhury
Copy link
Contributor

Housekeeping of DAGMC is very complicated now. And it seems in the docker file, we are just installing clang-format through apt. Also, I noticed the docker publish file is changed and there is no way to rebuild a new docker image for housekeeping.

@gonuke
Copy link
Member Author

gonuke commented Feb 19, 2024

@dean-krueger noted that clang-format does not know how to properly deal with our #pragma cycpp code. Some work may be necessary to add rules for clang-format to be useable.

@gonuke gonuke added the Style Updates in coding style without feature additions label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Style Updates in coding style without feature additions
Projects
Status: On Deck
Development

No branches or pull requests

3 participants