Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message memory management using smart pointers #6

Closed
rwcarlsen opened this issue Jan 31, 2012 · 1 comment
Closed

Message memory management using smart pointers #6

rwcarlsen opened this issue Jan 31, 2012 · 1 comment
Assignees
@rwcarlsen
Labels
Defect
Milestone
Release 0.1

Comments

@rwcarlsen
Copy link
Member

Use Boost shared_ptr and weak_ptr (to prevent parent/child cycles) for cyclus memory management. Eventually, the entire core needs to be converted from raw pointers to smart pointers. Note that the == operator still works for pointer comparisons between smart pointers.
katyhuff added a commit that referenced this issue Feb 3, 2012
@katyhuff
Changes the Material::comp() syntax to the more truthful isoVector() …
3fa5d04 
…syntax.

Also, changes situations where comp().comp() occured to iso_vector_.comp(). The 
former (comp().comp()) threw errors in Material::clone() function testing
(added here). The latter does not throw such errors.  

For reference, a backtrace of the sort of errors the former 
threw follows (the 'identifier' in question is always different, btw):


[----------] 2 tests from MaterialTest
[ RUN      ] MaterialTest.Constructors
[       OK ] MaterialTest.Constructors (0 ms)
[ RUN      ] MaterialTest.Clone
terminate called after throwing an instance of 'CycRangeException'
  what():  cyclus exception: Isotope identifier '574365655' is not valid.

Program received signal SIGABRT, Aborted.
0x00007fff85dbc0b6 in __kill ()
(gdb) bt
#0  0x00007fff85dbc0b6 in __kill ()
#1  0x00007fff85e5c9f6 in abort ()
#2  0x00007fff87d7e5d2 in __gnu_cxx::__verbose_terminate_handler ()
#3  0x00007fff87d7cae1 in __cxxabiv1::__terminate ()
#4  0x00007fff87d7cb16 in std::terminate ()
#5  0x00007fff87d7cbfc in __cxa_throw ()
#6  0x0000000100084be1 in IsoVector::validateIsotopeNumber ()
#7  0x0000000100084d2d in IsoVector::atomCount ()
#8  0x000000010008949b in Material::checkQuality ()
#9  0x00000001000e6616 in MaterialTest_Clone_Test::TestBody ()
#10 0x000000010159b7dd in testing::Test::Run ()
#11 0x00000001015a246e in testing::internal::TestInfoImpl::Run ()
#12 0x00000001015a25a4 in testing::TestCase::Run ()
#13 0x00000001015a2872 in testing::internal::UnitTestImpl::RunAllTests ()
#14 0x00000001015a29e9 in testing::UnitTest::Run ()
#15 0x0000000100020130 in main ()
(gdb)
@ghost ghost assigned rwcarlsen Feb 8, 2012
@rwcarlsen
Copy link
Member Author

actually, shared_ptr doesn't work for the Message class because of the way messages send themselves by passing their this pointers as an argument from inside the sendOn and approveTransfer methods. Using shared pointers would result in multiple shared pointer objects tracking the same Message object in memory (very bad). I will be using intrusive pointers to overcome this problem - each message object will track its own reference count.

rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
sed replaced Message* with msg_ptr (issue #6)
d1d73f0
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
sed added closing parens to many msg_ptr allocations (issue #6).
a6c6d1e
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
added typdef for msg_ptr. added boost smart_ptr include.
ab271df 
fixed gtest file that got corrupted from sed replace.

added forgotten boost namespace specifier.

see issue #6.
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
changed to boost::intrusive_ptr instead of smart_ptr (issue #6).
855975c
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
fixed more bugs w/ new smart pointer paradigm (issue #6).
62edaf8
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
fixed uninitialized intrusive_ptr bug in Source and Sink facility tes…
568cb9f 
…ts (issue #6).
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
switched to a dr. dobbs informed intrusive pointer base (issue #6) - …
8c49336 
…see http://drdobbs.com/cpp/229218807?pgno=1
rwcarlsen referenced this issue in rwcarlsen/cyclus Feb 8, 2012
@rwcarlsen
Added logging output and ref count tracking for message alloc/dealloc.
5cf1db1 
added MemAlloc prefix to log messages dealing with memory allocation.

see issue #6.
@rwcarlsen rwcarlsen mentioned this issue Feb 8, 2012
Closed
@gidden gidden mentioned this issue May 11, 2012
Closed
@gidden gidden mentioned this issue Mar 3, 2014
Closed
@rakhimov rakhimov mentioned this issue Apr 29, 2014
Merged
This was referenced Apr 30, 2014
Merged
Closed
@gidden gidden mentioned this issue Feb 23, 2015
Closed
@gidden gidden mentioned this issue Oct 14, 2015
Merged
@mbmcgarry mbmcgarry mentioned this issue Dec 16, 2016
Closed
@orpheus92 orpheus92 mentioned this issue May 19, 2017
Closed
@FlanFlanagan FlanFlanagan mentioned this issue Jun 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwcarlsen rwcarlsen

Labels
Defect
Projects
None yet
Milestone
Release 0.1
Development

No branches or pull requests
1 participant
@rwcarlsen