Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Index in the output database #603

Closed
katyhuff opened this issue Oct 4, 2013 · 14 comments
Closed

Create Index in the output database #603

katyhuff opened this issue Oct 4, 2013 · 14 comments
Labels
Best Practices Improvements in software development practices Comp: Output Side
Milestone

Comments

@katyhuff
Copy link
Member

katyhuff commented Oct 4, 2013

Suggestion from Yarden ( @yarden-livnat ) :

One of the last steps of database creation should be indexing (CREATE_INDEX ? )
Since it takes some time (how much?), it's likely that we will want a flag that turns off this feature for parametric simulation sets (because creating the index at the end of each simulation is fine, but is probably better to do just once at the end of the parametric series).

We should do this probably by adding a line to the create-table function for the sqlite backend that adds the name of that table to the list of tables to index.

Then, at the beginning of the close-table function in that sqlite backend, create an index based on that list.

@ghost ghost assigned scopatz Oct 4, 2013
@scopatz
Copy link
Member

scopatz commented Oct 23, 2013

Moved to 0.4

@scopatz
Copy link
Member

scopatz commented Feb 3, 2014

Moved to v0.5, probably should be post-1.0

@rwcarlsen
Copy link
Member

My post-processing tools do a fair amount of this. FWIW.

On Mon, Feb 3, 2014 at 6:00 AM, Anthony Scopatz notifications@github.comwrote:

Moved to v0.5, probably should be post-1.0

Reply to this email directly or view it on GitHubhttps://github.com//issues/603#issuecomment-33946832
.

@scopatz
Copy link
Member

scopatz commented Feb 3, 2014

I agree that this is mostly not relevant to the core.

@rwcarlsen
Copy link
Member

Now that I have more experience, we can't really guess what indices any user will want. There are divers permutations of indices and we certainly can't/shouldn't create them all. I don't think the core should try to guess. Post processing tools will create different indices depending on what we are post-processing for - e.g. create indices specific to cyclist, etc. I'd be fine with closing this issue.

@scopatz
Copy link
Member

scopatz commented Mar 7, 2014

Agreed for now.

@yarden-livnat
Copy link
Member

Indeed.
I don't think the core should create any indices, certainly not while it is still dumping data.

On Mar 7, 2014, at 3:06 PM, Robert Carlsen notifications@github.com wrote:

Now that I have more experience, we can't really guess what indices any user will want. There are divers permutations of indices and we certainly can't/shouldn't create them all. I don't think the core should try to guess. Post processing tools will create different indices depending on what we are post-processing for - e.g. create indices specific to cyclist, etc. I'd be fine with closing this issue.


Reply to this email directly or view it on GitHub.

@scopatz
Copy link
Member

scopatz commented May 17, 2014

Not going to happen by 1.0

@scopatz scopatz removed this from the v1.0 milestone May 17, 2014
@scopatz scopatz removed their assignment May 17, 2014
@rwcarlsen
Copy link
Member

FWIW my post-processing tool in cyan does this, but it won't be an
official part of the cyclus 1.0 release.

On Sat, May 17, 2014 at 11:45 AM, Anthony Scopatz
notifications@github.comwrote:

Not going to happen by 1.0


Reply to this email directly or view it on GitHubhttps://github.com//issues/603#issuecomment-43414262
.

@scopatz
Copy link
Member

scopatz commented Aug 26, 2014

Moved to 1.2

@scopatz scopatz added this to the v1.2 milestone Aug 26, 2014
@scopatz
Copy link
Member

scopatz commented Nov 24, 2014

Moved to v1.3

@scopatz scopatz modified the milestones: v1.3, v1.2 Nov 24, 2014
@gidden
Copy link
Member

gidden commented Apr 24, 2015

@rwcarlsen / @yarden-livnat, can you give an update on this issue?

@rwcarlsen
Copy link
Member

I think that this is the responsibility of cymetric, cyclist, and other
data analysis tools. I would vote for moving this issue into cymetric and
closing it here.

On Fri, Apr 24, 2015 at 10:38 AM, Matthew Gidden notifications@github.com
wrote:

@rwcarlsen https://github.com/rwcarlsen / @yarden-livnat
https://github.com/yarden-livnat, can you give an update on this issue?


Reply to this email directly or view it on GitHub
#603 (comment).

@gidden
Copy link
Member

gidden commented Apr 25, 2015

opening cyclus/cymetric#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Best Practices Improvements in software development practices Comp: Output Side
Projects
None yet
Development

No branches or pull requests

5 participants