Circle 2 GitHubAction #1569
Merged
Circle 2 GitHubAction #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to be working, but I'll wait for you to convert it from draft |
|
@gonuke I think I am happy with this now. since your last review, I just removed from circleCI the items I transferred to GitHubAction (build, unit_test, nosetest) and added a news file... |
gonuke
requested changes
Aug 13, 2021
|
@gonuke I rebased it. |
gonuke
approved these changes
Aug 14, 2021
| mkdir -p ${HOME}/.local/lib/python3.7/site-packages/ | ||
| cd ${GITHUB_WORKSPACE} | ||
| python install.py -j 2 \ | ||
| --build-type=Release --core-version 999999.999999 \ |
There was a problem hiding this comment.
Maybe I haven't noticed this before, but what is core-version and is this the right one?
|
Thanks @bam241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to convert our Circle CI to GithubAction