Buy policy can cycle back and forth between actively buying and dormant based on time step #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you rebase this, @nuclearkatie, we can see if the new tests pass |
nuclearkatie
force-pushed
the
buy_pol_time-based
branch
from
d648ee4
to
9c1517c
Compare
gonuke
requested changes
Nov 13, 2023
…e conditionsUpdate src/toolkit/matl_buy_policy.cc Co-authored-by: Paul Wilson <paul.wilson@wisc.edu> Signed-off-by: Katie Mummah <radioactivekate@gmail.com>
nuclearkatie
force-pushed
the
buy_pol_time-based
branch
from
8645a53
to
cb75553
Compare
gonuke
requested changes
Nov 24, 2023
|
In addition to adding a test for the active/dormant buying policy, I expanded the one main test ( I find it easier as a developer to have multiple smaller tests of one concept each than one larger test that is checking for multiple stacking concepts (sending a request, sending requests for multiple commodities, quantizing requests). At least, this makes it faster/easier to determine which part of the pre-existing code I broke. |
gonuke
reviewed
Nov 27, 2023
gonuke
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new buy policy parameters,
activeanddormant. Both are integers representing a number of time steps.activepart of the cycle, buying behavior is unchangeddormant, agent will not request any new material from DRE