Fix pythonpath #1609
Merged
Fix pythonpath #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonuke
added
the
Infrastructure: CI
docker/Dockerfile
Outdated
| @@ -44,6 +44,8 @@ RUN apt install -y python3-pprintpp; exit 0 | |||
| RUN apt clean -y all | |||
|
|
|||
| RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 10 | |||
| RUN mkdir -p `python -m site --user-site` | |||
| ENV PYTHONPATH `python -m site --user-site` | |||
There was a problem hiding this comment.
When I build this image I'm seeing $PYTHONPATH equal to "`python -m site --user-site`" and not the actual output of that command (confirmed by various articles). Might need to figure out something more clever to set this dynamically
There was a problem hiding this comment.
The options I'm seeing are:
- set it in the
CMD(don't think this will work with multiple stages since theRUNsteps will run in different shells - store it in a file? (doesn't really solve anything if we need to run a script to set the env var)
- change the site-packages directory to something we know, so that we know where cyclus is installed and we can safely hardcode the PYTHONPATH (I'm trying to see if this is possible)
There was a problem hiding this comment.
Actually... do we need to explicitly set the PYTHONPATH env var? When I omit that line and build images, the correct site-packages directory is in sys.path and all tests pass (besides test_main.py of course). The best solution might be to delete lines 48 and 110 altogether
bennibbelink
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure user-site path is created at right stage.
Fix PYTHONPATH to be not hardcoded
Fixes #1610