Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build new docker images on all pushes to main not just with specifi… #1629

Merged
merged 3 commits into from Nov 27, 2023

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Nov 27, 2023

Fixes #1628

We currently only pushed new docker images when pushes to main were caused by changes in specific files. This means that there is no up-to-date image based on the most current state of main for downstream repos.

This fix causes all pushes to main to cause an update of the docker images tagged as latest. In the future, once we have a working release, we can add to the images with a stable based on the latest release.

Copy link
Contributor

@bennibbelink bennibbelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bennibbelink bennibbelink merged commit ee434a2 into main Nov 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build new cyclus docker image for downstream testing on push to main
2 participants