Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zlib as dependency in README #1644

Merged
merged 3 commits into from Jan 15, 2024
Merged

Conversation

bennibbelink
Copy link
Contributor

The version listed is the lowest version in the 4 builds we have in CI (apt-20.04)

@bennibbelink bennibbelink linked an issue Jan 13, 2024 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Jan 13, 2024

Pull Request Test Coverage Report for Build 7512258369

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 49.335%

Totals Coverage Status
Change from base Build 7027753240: -0.001%
Covered Lines: 23971
Relevant Lines: 41349

💛 - Coveralls

@bennibbelink bennibbelink marked this pull request as ready for review January 13, 2024 12:11
@gonuke
Copy link
Member

gonuke commented Jan 13, 2024

Do we need a more careful review/revision of our dependencies? I've been holding off until we get close to release to make sure everything is up to date.

@gonuke
Copy link
Member

gonuke commented Jan 15, 2024

I'll merge this and we can make a separate issue to review closer to release time.

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink

@gonuke gonuke merged commit ebea144 into cyclus:main Jan 15, 2024
11 checks passed
@bennibbelink bennibbelink deleted the zlib-readme branch February 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add zlib as a dependency in README
3 participants