New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Updates #1668
CI Updates #1668
Conversation
Pull Request Test Coverage Report for Build 7920887563Details
💛 - Coveralls |
Something this PR also does is add a trigger for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we are done for now?
Hopefully 🤞 |
This fixes the CI permissions problems we're seeing (along with cymetric #195 and cycamore #583). Sorry that this hasn't gone as smoothly as possible, hopefully this is the last major refactor.
Changes are as follows:
build_test.yml
does not push any images to the cyclus GHCR. Instead it uses a local docker registry on the GitHub runner. This way we don't experience permissions errors with PRs from forks. This adds a tiny bit of complexity that I wanted to avoid, but honestly I think the workflow might be more intuitive now than in previous iterations. I tried implementing this without a local registry service but docker automatically tries to pull metadata so I was seeing lots of permission errors.publish_latest.yml
is the only workflow that updates the layer cache. This way all workflows essentially pull the layers that build the dependency image incyclus:latest
. Most workflows pull from this cachecode_coverage.yml
has its own cache since its dependencies are slightly different, but I've included theignore-error
option so that cache-to won't stop a workflow from passing in a PRpublish_latest.yml
andpublish_release.yml
) need to be updated from a branch on the upstream repository. This is similar to our previous strategylatest
. This is to eliminate some verbosity in the workflow files and ensure users are using the latest versions when building from the DockerfileOnce again I've reference branches in cycamore and cymetric corresponding to their respective PRs with these changes