Resolve Pytest warnings #1684
Merged
Resolve Pytest warnings #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream Build Status ReportBuild
|
Pull Request Test Coverage Report for Build 8193236620Details
💛 - Coveralls |
gonuke
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks @bennibbelink - this looks clear/clean and passes tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many instances in
cycpp.pywhere a standard string is used instead of a raw string literal leading to incorrect escaping. This led to a failing test mentioned in #1683. This PR resolves the regex warnings along with a handful of other pytest warnings. Pytest should run cleanly now with no warnings.