throw if invalid package id given #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearkatie
force-pushed
the
getpackageid
branch
from
821b72b
to
9561e88
Compare
Downstream Build Status ReportBuild
|
Pull Request Test Coverage Report for Build 8273303447Details
💛 - Coveralls |
bennibbelink
approved these changes
Mar 14, 2024
gonuke
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Looks like this does the trick. Thanks for the quick fix @nuclearkatie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built errors into
GetPackageByNamebut forgot to do so forGetPackageById. Throws for bothid< 0 and unable to find matchingidCloses #1697