Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp/SHA to PR comment #1708

Merged
merged 14 commits into from Mar 24, 2024
Merged

Add timestamp/SHA to PR comment #1708

merged 14 commits into from Mar 24, 2024

Conversation

bennibbelink
Copy link
Contributor

Closes issue #1707. Adds a timestamp and commit hash to the PR comment generated on downstream testing

@bennibbelink bennibbelink linked an issue Mar 23, 2024 that may be closed by this pull request
Copy link

Downstream Build Status Report

Build FROM cyclus_20.04_apt/cyclus
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_20.04_conda/cyclus
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_apt/cyclus
  • Cycamore: Success
  • Cymetric: Success
Build FROM cyclus_22.04_conda/cyclus
  • Cycamore: Success
  • Cymetric: Success

@coveralls
Copy link
Collaborator

coveralls commented Mar 23, 2024

Pull Request Test Coverage Report for Build 8410579111

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.594%

Totals Coverage Status
Change from base Build 8381657162: 0.0%
Covered Lines: 53047
Relevant Lines: 129057

💛 - Coveralls

@bennibbelink
Copy link
Contributor Author

bennibbelink commented Mar 23, 2024

Unfortunately we're not seeing what the comment will look like after this PR is merged. I think it might be because of how pr_comment.yml is triggered (by the completion of build_test.yml). This is what the header of the comment will look like:

Downstream Build Status Report - 10ba101

@bennibbelink bennibbelink marked this pull request as ready for review March 23, 2024 03:18
@bennibbelink bennibbelink marked this pull request as draft March 23, 2024 03:19
@bennibbelink bennibbelink marked this pull request as ready for review March 23, 2024 03:23
@gonuke
Copy link
Member

gonuke commented Mar 23, 2024

I this meant to add a timestamp as well? or just a commit hash?

@bennibbelink
Copy link
Contributor Author

I initially had it add a timestamp too but figured the commit hash was more relevant. Forgot to change the PR title. I can add the timestamp back in if you'd like me to.

@gonuke
Copy link
Member

gonuke commented Mar 24, 2024

I think both are useful since it can often be easier to check the timestamp without cross-referencing

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink - let's give this a shot

@gonuke gonuke merged commit bf6797c into main Mar 24, 2024
17 checks passed
@bennibbelink bennibbelink deleted the hash-comment branch March 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamp to PR Comment
3 participants