Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpackaged as default Package id #1711

Merged
merged 3 commits into from Mar 27, 2024
Merged

Unpackaged as default Package id #1711

merged 3 commits into from Mar 27, 2024

Conversation

nuclearkatie
Copy link
Contributor

Closes #1692

gonuke
gonuke approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This subtle change will have a big impact on readability and maintainability in the long run. Thanks @nuclearkatie

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited

Downstream Build Status Report - 6cd649b - 2024-03-27 14:21:00 +0000

Build FROM cyclus_20.04_apt/cyclus
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus
  • Cycamore: Success ✅
  • Cymetric: Success ✅

@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2024 •
edited

Pull Request Test Coverage Report for Build 8453343044

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 32.599%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/material.cc 2 3 66.67%
src/product.cc 0 1 0.0%
Totals Coverage Status
Change from base Build 8441370712: 0.003%
Covered Lines: 53061
Relevant Lines: 129063
💛 - Coveralls

@gonuke gonuke merged commit 31c9789 into cyclus:main Mar 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bulk-to-Discrete packaging
Development

Successfully merging this pull request may close these issues.

Tweak implementation of default_package_id_
3 participants
@nuclearkatie @coveralls @gonuke