add tests for Package #1712
add tests for Package #1712
Conversation
src/product.cc
Outdated
| if (ctx_ == NULL) { | ||
| throw ValueError("Package Id cannot be changed with NULL context"); | ||
| } |
There was a problem hiding this comment.
@nuclearkatie - in material.cc we just return rather than throwing an error in this case. Do we need to throw an error?
There was a problem hiding this comment.
I think you're right, we should probably just return
Downstream Build Status Report - 6aa3f9e - 2024-03-30 21:24:30 +0000Build
|
Pull Request Test Coverage Report for Build 8493492016Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This looks good to me @gonuke. Do you plan to add more tests to it? If not I'll merge if you convert from draft |
|
I was going to add tests for |
src/product.cc
Outdated
| if (ctx_ == NULL) { | ||
| throw ValueError("Package Id cannot be changed with NULL context"); | ||
| } |
There was a problem hiding this comment.
I think you're right, we should probably just return
Co-authored-by: Katie Mummah <radioactivekate@gmail.com> Signed-off-by: Paul Wilson <paul.wilson@wisc.edu>
Some simple tests for Package - hoping for a positive change to coverage!