Default to Release build #1741
Merged
Default to Release build #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream Build Status Report - 1d0eaee - 2024-04-30 12:57:48 -0500Build
|
Pull Request Test Coverage Report for Build 8899434289Details
💛 - Coveralls |
gonuke
requested changes
Apr 30, 2024
install.py
Outdated
Comment on lines
82
to
83
| else: | ||
| cmake_cmd += ['-DCMAKE_BUILD_TYPE=Release'] |
There was a problem hiding this comment.
Or should we set a default in the argparse declaration of this CLI parameter?
There was a problem hiding this comment.
That is a better solution, thanks for the suggestion @gonuke
|
Do we need the same change for Cycamore? |
|
Yes, please see cyclus/cycamore#600 |
gonuke
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
install.pyto set-DCMAKE_BUILD_TYPE=Releaseif no--build-typeis specified. Removes this flag from the dockerfiles where we install cyclus.