added file and cli flag for retrieving cyclus core and dependency versions #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const char* xmlpp() { | ||
| return "???"; | ||
| }; |
There was a problem hiding this comment.
Looking at the xml++ source code, I don't think that this is possible to know at run time. Which is LAME! However, given that, I'd rather remove this function and increase the signal to noise than display something unknowable.
|
Hey @rwcarlsen, great work! Thanks for doing this. Just see my note about removing the xmlpp refs. |
|
rebased - removed xml++ version func. |
|
Thanks. Looks good to me. Taking it for a test drive now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578.