Use GET with :developer strategy. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes the default method of the :developer strategy to GET. It does this by allowing OmniAuth::Form to accept a `:method` option, which is optional and defaults to 'post', the current behavior. Because the default behavior remains unchanged, I don't expect this to introduct any breaking changes. This allows the developer strategy to work with the directions provided in the README. Further, it seems that the default action of most stratigies is to use GET for their callbacks. Fixes omniauth#1087 Fixes omniauth#1061 Fixes omniauth#957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes the default method of the :developer strategy to GET. It does
this by allowing OmniAuth::Form to accept a
:methodoption, which isoptional and defaults to 'post', the current behavior. Because the default
behavior remains unchanged, I don't expect this to introduct any breaking
changes.
This allows the developer strategy to work with the directions provided in
the README. Further, it seems that the default action of most stratigies is
to use GET for their callbacks.
Fixes omniauth#1087 Fixes omniauth#1061 Fixes omniauth#957