Title resets when window is minimised

[fnxweb]

When a KiTTY window is minimised, the title gets reset to either the title it first set upon connection (usually “hostname - KiTTY”) or the one that was current when the settings dialogue was last opened.

E.g., when bash's PROMPT_COMMAND is set to show the current directory in the title, this is cleared to the above upon minimise. If the window settings are opened while it is set to a directory (and that dir. is then shown in the settings' window title), then that is the value to goes back to in the future when minimised (even if apply isn't clicked to close the dialogue).

[lars18th]

Hi,

I confirm that this bug continues.

Try this @cyd01 please:

• kitty.exe -title TEST ...

Then the NAME of the Window will be for example the path of the shell. After that you can minimize the window. And after you can reopen the window, but then you'll see that the TITLE NAME is now "TEST" instead of the previous one.

I hope you can fix it.
Regards.

[lars18th]

Please @fnxweb check last version. I feel this bug is solved.

[fnxweb]

Bug still present in 0.73.1.5 I'm afraid.

[lars18th]

Hi @cyd01 ,

Tested with the last version 0.73.2.3: If I execute kitty.exe -title TEST ... then the word "TEST" appears in the Title Window. All OK. And I can minimize and restore, and it works.

However, if after that I execute kitty.exe ... (that's without changing the title with the parameter -title) then continues to appear the word "TEST" in the title. I feel something is stored from the previous session.

Please, check it. Other than that, I think the problem is solved.
Regards.

[cyd01]

I did not reproduced. I've checked the code (search for -title in window.c).

		} else if( !strcmp(p, "-title") ) {
			i++ ;
			conf_set_str( conf, CONF_wintitle, argv[i] );

The is no reason for the specified title is stored ... are you sure you did not save the session before running it (check Window\Behavior panel) ?

[lars18th]

I did not reproduced. I've checked the code (search for -title in window.c).

		} else if( !strcmp(p, "-title") ) {
			i++ ;
			conf_set_str( conf, CONF_wintitle, argv[i] );

The is no reason for the specified title is stored ... are you sure you did not save the session before running it (check Window\Behavior panel) ?

No. I run it from the command line! 😨

[fnxweb]

The issue is still present in 0.73.2.3 I'm afraid.

• Open a session — my login sets the title to the CWD immediately (“title 1”)
• Minimise then un-minimise window : title is reset to “IP-address/host - KiTTY”
• Set the title via the session / terminal escape sequences (“title 2”)
• Open settings and just then close settings : “title 2” “stored”
• Change title again (“title 3”)
• Minimise then open again: title has reverted to “title 2”

[lars18th]

Hi @fnxweb ,

I think the same, the problem is not fixed. Something is wrong in the logic of the windows's title.

Regards.

[systemmonkey42]

Hi @cyd01

The issue is still present in 0.73.2.4. (Portable, if that makes a difference).

Any attempt to resize the window will immediately reset the window title to the original title (either whatever is configured/saved in the config, or the default "HOST - KiTTY" title)

Regards

[lars18th]

Hi @systemmonkey42 ,

Then it will clear that's a problem with the title management. I hope @cyd can fix it at some point.

Regards.

[systemmonkey42]

I think I've found the source of the problem.

Open kitty.ini and look for wintitle= in the KiTTY section.

Setting wintitle=no will keep remotely set titles

The default causes the remotely set title to be cleared every time the window size changes.

[fnxweb]

I don't think that'll help my use case, since I'm trying to keep my remotely set window titles, not disable them.

[systemmonkey42]

My wording is not the best. The default of wintitle=yes resets the remotely set title on every window size change.

Set it to no to allow remotely set title to stay set.

This does not disable remotely set titles.

[fnxweb]

Confirmed, thanks @systemmonkey42 — setting [KiTTY] / wintitle=no in a kitty.ini next to kitty.exe fixes/works around the problem.

I don't know what that setting is intended to do, it's not a mirror of the enable/disable-remote-window-titles setting in the GUI, so I don't know if there's another side effect.

[lars18th]

Hi,

As defined here:

KiTTY/0.73_My_PuTTY/putty.h

Line 1385 in e9be5bd

X(BOOL, NONE, no_remote_wintitle) /* disable remote retitling */ \

KiTTY/kitty_settings.c

Line 160 in e9be5bd

write_setting_b_forced(sesskey, "NoRemoteWinTitle", conf_get_bool(conf, CONF_no_remote_wintitle));

The [KiTTY] / wintitle=no entry is to disable all the title management. But as defined here it's too another config variable to enforce a title:

KiTTY/0.73_My_PuTTY/settings.c

Line 706 in e9be5bd

write_setting_s(sesskey, "WinTitle", conf_get_str(conf, CONF_wintitle));

Futhermore, if you check the code searching for "wintitle" your see lines like these:

KiTTY/0.73_My_PuTTY/terminal.c

Line 2779 in 54ea495

if (!term->no_remote_wintitle)

KiTTY/0.73_My_PuTTY/windows/winctrls.c

Line 2622 in 6561c7d

sfree(dp->wintitle);

IMO, I feel the problem is related to an inconsistent processing of the title. I suspect that multiple actors are changing the title. Then some refactoring is required.

I hope it helps.
Regards.

[lars18th]

Hi @cyd01 ,

Do you reviewed the code regarding the wintitle variable?

[cyd01]

Not yet. Le mar. 12 mai 2020 à 16:17, Lars The <notifications@github.com> a écrit :

…

Hi @cyd01 <https://github.com/cyd01> , Do you reviewed the code regarding the wintitle variable? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIESOBWZD4M57Y6PACKUPS3RRFLAJANCNFSM4H7FTBRQ> .

[cyd01]

Title is controlled by window event of course ... but it is controlled by terminal too.
You must check disable remote-controlled window title changing in Terminal/Features configuration panel.