Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssetMaker.php #7

Closed
Tony-S opened this issue Apr 8, 2020 · 5 comments
Closed

Update AssetMaker.php #7

Tony-S opened this issue Apr 8, 2020 · 5 comments
Assignees
Labels

Comments

@Tony-S
Copy link

Tony-S commented Apr 8, 2020

AssetMaker trait needs updating with changes in modules/system/traits/AssetMaker.php. Specifically it doesn't handle assets being passed in an array e.g. in a component $this->addCss('assets/css/uploader.css'); works but $this->addCss(['assets/css/uploader.css']); doesn't. See octobercms/october@aeb7616 (but there could be other changes).

@cydrickn cydrickn self-assigned this Apr 8, 2020
@cydrickn
Copy link
Owner

cydrickn commented Apr 8, 2020

Hi @Tony-S,
I will check this and test.

@cydrickn cydrickn added the bug label Apr 8, 2020
@Tony-S
Copy link
Author

Tony-S commented Apr 8, 2020

Thanks. I've updated the copy of AssetMaker.php in your plugin by adding your changes back into a latest version of AssetMaker and all is working fine now front and backend.

@cydrickn
Copy link
Owner

Thanks, will you create a Pull Request for this?

cydrickn added a commit that referenced this issue Apr 12, 2020
@cydrickn
Copy link
Owner

Hi @Tony-S
I already push the fix for this.

I will include this with version v1.1.1

@Tony-S
Copy link
Author

Tony-S commented Apr 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants