-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AssetMaker.php #7
Labels
Comments
Hi @Tony-S, |
Thanks. I've updated the copy of AssetMaker.php in your plugin by adding your changes back into a latest version of AssetMaker and all is working fine now front and backend. |
Thanks, will you create a Pull Request for this? |
Hi @Tony-S I will include this with version v1.1.1 |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AssetMaker trait needs updating with changes in modules/system/traits/AssetMaker.php. Specifically it doesn't handle assets being passed in an array e.g. in a component
$this->addCss('assets/css/uploader.css');
works but$this->addCss(['assets/css/uploader.css']);
doesn't. See octobercms/october@aeb7616 (but there could be other changes).The text was updated successfully, but these errors were encountered: