Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls fail on links > 80 chars #34

Closed
sckasturi opened this issue May 21, 2014 · 5 comments
Closed

urls fail on links > 80 chars #34

sckasturi opened this issue May 21, 2014 · 5 comments

Comments

@sckasturi
Copy link
Contributor

@cydrobolt
Copy link
Owner

The issue pertained only to TempURLs, since the schema was imported from a previous version of Polr. Thanks @sckasturi for reporting this bug, it has been fixed. (limit is now 250 for tempurls)

Additional note: the temp table was truncated.

@sckasturi
Copy link
Contributor Author

personally I would not set a limit as urls themselves dont have a limit.

Sent from my Samsung Galaxy S3
On May 21, 2014 3:29 PM, "Chaoyi Zha" notifications@github.com wrote:

The issue pertained only to TempURLs, since the schema was imported from a
previous version of Polr. Thanks @sckasturi https://github.com/sckasturifor reporting this bug, it has been fixed. (limit is now 250 for tempurls)

Additional note: the temp table was truncated.


Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-43802947
.

@cydrobolt
Copy link
Owner

I know this, but we can't have people DoSing our servers by making "urls" that are extremely long

@sckasturi
Copy link
Contributor Author

then instead of only shortening the first 80 chars of the url I would
raise an error.

@cydrobolt
Copy link
Owner

will look into expanding the limit, and/or giving an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants