Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit in osm button doesn't work #48

Open
Robinlovelace opened this issue Mar 20, 2018 · 10 comments
Open

Edit in osm button doesn't work #48

Robinlovelace opened this issue Mar 20, 2018 · 10 comments
Labels

Comments

@Robinlovelace
Copy link
Contributor

It takes you to a non-existent element, e.g. here: https://www.cyipt.bike/existing/#18/53.81114/-1.53611/satellite

@Robinlovelace
Copy link
Contributor Author

Any ideas @mvl22 ?

@mvl22
Copy link
Contributor

mvl22 commented Mar 20, 2018

@mem48 This is caused by an exponent still in the data. I believe you said these should now be updated - can you confirm?

Link takes you to /way/1.02096e+07 which is obviously wrong.

mvl22 added a commit that referenced this issue Mar 20, 2018
@mvl22
Copy link
Contributor

mvl22 commented Mar 20, 2018

Workaround now in place.

@mvl22 mvl22 removed the priority label Mar 20, 2018
@Robinlovelace
Copy link
Contributor Author

Seems a bit hit and miss. Click Edit OSM here https://www.cyipt.bike/#19/53.81065/-1.54147/mapnik for example, takes me to one of the most remote spots on Earth!

This one works though: https://www.cyipt.bike/#19/53.81139/-1.53741/mapnik

@mem48
Copy link
Contributor

mem48 commented Mar 20, 2018

@mvl22 I'm looking into this I thought I had fixed it

@mvl22
Copy link
Contributor

mvl22 commented Mar 21, 2018

Is the exponent issue fixed, Malcolm?

@mem48
Copy link
Contributor

mem48 commented Mar 22, 2018

Yes I've updated the database and forces integer numbers, it now seems to be working see the output data https://www.cyipt.bike/api/v1/existing.json?key=c047ed46f7b50b18&zoom=17&layer=speedlimits&bbox=-2.596443%2C51.449320%2C-2.591507%2C51.454950

However I've noticed that sometimes the link goes to the wrong place, I'm not sure the reason for this

@mvl22
Copy link
Contributor

mvl22 commented Mar 22, 2018

However I've noticed that sometimes the link goes to the wrong place, I'm not sure the reason for this

Let me know an example and I can look at this. Possibly they aren't Ways.

@Robinlovelace
Copy link
Contributor Author

Here (mentioned above): https://www.cyipt.bike/#19/53.81065/-1.54147/mapnik

The path connecting to Oatland Place takes you to the middle of nowhere.

@mvl22
Copy link
Contributor

mvl22 commented Mar 22, 2018

The link takes you to:
https://www.openstreetmap.org/way/236285584

but the Way number is:
https://www.openstreetmap.org/way/236285578

So I think the script is messing things up somewhere along the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants