fix: prevent from calling Date.prototype.toJSON

cyjake · Aug 5, 2021 · 81368fc · 81368fc
1 parent 6d0ac83
commit 81368fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/bone.js b/src/bone.js
@@ -470,7 +470,7 @@ class Bone {
       if (typeof this[key] !== 'function') {
         const value = this[key];
         if (value != null) {
-          obj[key] = typeof value.toJSON === 'function' ? value.toJSON() : value;
+          obj[key] = value instanceof Bone ? value.toJSON() : value;
         }
       }
     }

diff --git a/test/integration/suite/basics.test.js b/test/integration/suite/basics.test.js
@@ -404,13 +404,11 @@ describe('=> Integration', function() {
     const post = await Post.findOne({ title: 'New Post' });
     const result = post.toJSON();
 
-    delete result.updatedAt;
-    delete result.createdAt;
-
     expect(result).to.be.an('object');
     expect(result.id).to.be.ok();
     expect(result.title).to.equal('New Post');
     expect(result.extra).to.eql({ versions: [2, 3] });
+    assert(result.createdAt instanceof Date);
   });
 
   it('bone.toJSON() with missing attributes', async function() {