Rose suite run proposals cylc flow.rc #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Roadmap for small PRs to a dev branch added. - Clarification of terminology for job platforms - Some thoughts on `cylc flow --options` - Added stub files for development plan documentation
wxtim
requested review from
matthewrmshin,
hjoliver,
kinow,
oliver-sanders and
sadielbartholomew
docs/proposal-rose-suite-run.md
Outdated
|
|
||
|
|
||
| - [ ] Implement Cluster support functionality. [Cylc-flow #2199](https://github.com/cylc/cylc-flow/issues/2199) | ||
| - [ ] Modify `task_job_mgr.py` to use the new variables. |
There was a problem hiding this comment.
And maybe modules like cylc.task_remote_mgr and friends.
There was a problem hiding this comment.
and friends? Would you care to use your domain knowledge to help me a bit more?
Are these the files in the result of grep -lrinP "cylc.flow.cfgspec"
| ... | ||
| [suite host self-identification] | ||
| ... | ||
| [authentication] |
There was a problem hiding this comment.
Should become [authorisation].
There was a problem hiding this comment.
Agreed, with spelling "authorization" which is acceptable (if archaic) in all forms of English.
There was a problem hiding this comment.
That's a truly beautiful depiction of a can of worms, @wxtim 😆 Thank you for your commitment to humour!
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
…tim/cylc-admin into rose-suite-run-proposals-cylc-flow.rc * 'rose-suite-run-proposals-cylc-flow.rc' of github.com:wxtim/cylc-admin: Update docs/proposal-rose-suite-run.md Update docs/rose-suite-run-proposal/cylc-flow-rc.md
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
Co-Authored-By: Matt Shin <matthew.shin@metoffice.gov.uk>
…tim/cylc-admin into rose-suite-run-proposals-cylc-flow.rc * 'rose-suite-run-proposals-cylc-flow.rc' of github.com:wxtim/cylc-admin: Update docs/proposal-rose-suite-run.md Update docs/proposal-rose-suite-run.md
matthewrmshin
approved these changes
Aug 21, 2019
Co-Authored-By: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
…tim/cylc-admin into rose-suite-run-proposals-cylc-flow.rc * 'rose-suite-run-proposals-cylc-flow.rc' of github.com:wxtim/cylc-admin: Update docs/proposal-rose-suite-run.md
kinow
approved these changes
Aug 26, 2019
docs/proposal-rose-suite-run.md
Outdated
| metadata. Rose apps should be validated against their metadata by default, | ||
| but contain switches in the manner of bandit or pylint in a config file. | ||
| (perhaps `cylc-validate.yml` or similar) | ||
| * Creators of largers suites may want to turn this because the validation |
There was a problem hiding this comment.
I've actuall removed this after a conversation with Oliver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #40.
cylc-flow.rcfile.