Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle out of order task messages #351

Closed
matthewrmshin opened this issue Mar 12, 2013 · 3 comments
Closed

Handle out of order task messages #351

matthewrmshin opened this issue Mar 12, 2013 · 3 comments
Assignees
Milestone

Comments

@matthewrmshin
Copy link
Contributor

This consolidates the remaining issue in #115 and #192.

... currently a task proxy goes into the failed state if it gets a succeeded message before a started message - whereas we should assume the succeeded message is genuine and the started message just didn't get through for some reason.

(A related issue: (@hjoliver please correct me if I am wrong...) The time of an event is currently recorded as the time when the suite receives the message. In the circumstance when a suite fails to receive the message at the correct time of the event, the recorded time of the event will be incorrect. It would be nice if the actual event time is also sent with the message in these circumstances.)

See also #350.

@hjoliver
Copy link
Member

The time of an event is currently recorded as the time when the suite receives the message.

That's correct Matt.

@hjoliver
Copy link
Member

Note I've moved the "related issue" above to #380.

@hjoliver
Copy link
Member

This issue is done when #364 is merged. Currently on that feature branch:

  • succeeding before all outputs completed just results in a warning and artificially completes all outputs.
    • this applies to succeeded message arriving before started too.
  • receiving additional messages after succeeded just generates warnings
  • the order of internal outputs doesn't matter.

@ghost ghost assigned hjoliver Apr 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants