Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequential clock trigger bug #6204

Closed
hjoliver opened this issue Jul 7, 2024 · 2 comments · Fixed by #6206
Closed

sequential clock trigger bug #6204

hjoliver opened this issue Jul 7, 2024 · 2 comments · Fixed by #6206
Assignees
Labels
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 7, 2024

Only one task can trigger off of a sequential clock trigger, after the first cycle.

This only affects clock triggers, not other xtriggers.

Example: after the first cycle, only a, p, and q will spawn ahead and run:

[scheduler]
    allow implicit tasks = True
[scheduling]
    initial cycle point = 2000
    [[xtriggers]]
        x = wall_clock(sequential=True)
        y = xrandom(50, _=%(point)s, sequential=True)
    [[graph]]
        PT1M = """
            @x => a & b
            @y => p & q
        """

Setting sequential=False restores correct (but non-sequential) behaviour.

@hjoliver hjoliver added the bug label Jul 7, 2024
@hjoliver hjoliver added this to the 8.3.2 milestone Jul 7, 2024
@dwsutherland
Copy link
Member

Found the problem: If a wall_clock xtrigger had already been satisfied, the task ids weren't added to the spawn next set.

@oliver-sanders oliver-sanders linked a pull request Jul 8, 2024 that will close this issue
7 tasks
@oliver-sanders
Copy link
Member

Closed by #6206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants