Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequential clock spawning fix #6206

Merged

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Jul 8, 2024

closes #6204

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@dwsutherland dwsutherland added this to the 8.3.2 milestone Jul 8, 2024
@dwsutherland dwsutherland self-assigned this Jul 8, 2024
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested as working; I've added an integration test at dwsutherland#21

@oliver-sanders oliver-sanders linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a pending (possibly via @MetRonnie )

Test that all tasks dependent on a sequential clock trigger continue to spawn after the first cycle
@dwsutherland
Copy link
Member Author

Manually tested as working; I've added an integration test at dwsutherland#21

Thanks Ronnie

@oliver-sanders oliver-sanders merged commit ae6a70d into cylc:8.3.x Jul 9, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequential clock trigger bug
4 participants