Supply URLs to suite and task event handlers. #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
commented
May 11, 2017
| @@ -316,9 +320,6 @@ def __init__( | |||
| self.TABLE_TASK_STATES: [], | |||
| } | |||
|
|
|||
| # TODO - should take suite name from config! | |||
| self.suite_name = os.environ['CYLC_SUITE_NAME'] | |||
There was a problem hiding this comment.
Doesn't need to be an instance variable, and this was an insane way of getting the suite name.
hjoliver
commented
May 11, 2017
| @@ -23,7 +23,7 @@ OPT_SET= | |||
| if [[ "${TEST_NAME_BASE}" == *-globalcfg ]]; then | |||
| create_test_globalrc "" " | |||
| [task events] | |||
| handlers=hello-event-handler '%(name)s' '%(event)s' | |||
| handlers = hello-event-handler %(name)s %(event)s %(suite_url)s %(task_url)s %(message)s %(point)s %(submit_num)s %(id)s | |||
There was a problem hiding this comment.
Might as well test all possible args.
|
Will be very minor conflicts with 2157 |
There was a problem hiding this comment.
Please consider modifying url to URL in the docs. Looks OK in general, and should be relatively straightforward to merge/port into #2157.
doc/src/cylc-user-guide/suiterc.tex
Outdated
| @@ -1546,6 +1547,8 @@ \subsection{[runtime]} | |||
| \item \%(suite)s: suite name | |||
| \item \%(point)s: cycle point | |||
| \item \%(name)s: task name | |||
| \item \%(suite_url)s: suite url | |||
| \item \%(task_url)s: task url | |||
There was a problem hiding this comment.
Should be URL (ALL CAPS), to be consistent with line 304 above.
|
@oliver-sanders please sanity check. I am tempted to just merge this and have the docs fixed when I resolve the conflicts in #2157. |
|
Changed 'url' to 'URL' in the user guide. |
matthewrmshin
approved these changes
May 11, 2017
oliver-sanders
approved these changes
May 11, 2017
matthewrmshin
added a commit
to matthewrmshin/cylc-flow
that referenced
this pull request
May 11, 2017
Fixes following merge with cylc#2276.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2275
Not for review yet - just needs tests.Tests added (or rather, existing tests upgraded).