scan/gscan: consistent default behaviour #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
approved these changes
May 16, 2018
| cres = {'owner': None, 'name': None} | ||
| for label, items in [('owner', patterns_owner), ('name', patterns_name)]: | ||
| if items: | ||
| cres[label] = r'\A(?:' + r')|(?:'.join(items) + r')\Z' |
There was a problem hiding this comment.
I think this is probably the right way to go but It's worth noting this is a change in behaviour, partial patterns used to match.
There was a problem hiding this comment.
Added an entry to CHANGES.md and modified the cylc scan syntax on cylc run daemonize.
By default, scan only running suites of current user by looking at `~/cylc-run/*/.service/contact` of current user.
Note that `cylc scan --name=PATTERN` will require a pattern to match full names of suites.
matthewrmshin
force-pushed
the
fix-scan-default
branch
from
66dc7b8
to
66bffb0
Compare
|
Branch re-based. |
hjoliver
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, scan only running suites of current user by looking at
~/cylc-run/*/.service/contactof current user.Address the bug label of #2663.