Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flaky tests #3244

Merged
merged 1 commit into from Jul 26, 2019
Merged

More flaky tests #3244

merged 1 commit into from Jul 26, 2019

Conversation

matthewrmshin
Copy link
Contributor

These changes partially address #2894

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • These changes are already covered by existing tests.
  • No change log entry required (e.g. change is small or internal only).
  • No documentation update required for this change.

@matthewrmshin
Copy link
Contributor Author

Looks like these are failing on Travis CI:

  • database/01 and database/02: The database entry contains the full host name running the Travis job instead of the string localhost.
  • restart/39 and restart/40: Reason unknown. An expected line is no longer in the log? I'll add some diagnostics in.

@kinow
Copy link
Member

kinow commented Jul 25, 2019

Looks like these are failing on Travis CI

It doesn't make any sense that these tests (especially the one about the travis host name being used instead of localhost) didn't fail before. I saw the Travis failure some hours ago, but looks like you just pushed a change.

Will review once Travis is done building (and has hopefully passed this time :) )

@kinow
Copy link
Member

kinow commented Jul 25, 2019

Hmm, failure on Travis. Not related?

2019-07-25T22:54:49Z INFO - Processing 1 queued command(s)
	+       set_stop_cleanly(kill_active_tasks=True)
2019-07-25T22:54:49Z INFO - Suite shutting down - REQUEST(CLEAN)
2019-07-25T22:54:50Z INFO - DONE
    stdout and stderr stored in: /tmp/travis/cylctb-20190725T223135Z/restart/40-auto-restart-force-stop
[22:54:23] ./flakytests/restart/40-auto-restart-force-stop.t ........ Failed 1/4 subtests 
	(less 3 skipped subtests: 0 okay)

@dwsutherland
Copy link
Member

Definitely flaky... passed on my machine..

@matthewrmshin matthewrmshin force-pushed the more-flaky-tests branch 2 times, most recently from aa04f5e to 4fb25fe Compare July 26, 2019 11:05
@matthewrmshin
Copy link
Contributor Author

Finally pass with a workaround!

@matthewrmshin
Copy link
Contributor Author

All of them are to do with host name. For some reason, our logic is now returning the literal string localhost instead of the fully qualified domain name.

Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants