Fix task event handler start time #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
commented
Aug 28, 2019
| @@ -792,7 +792,6 @@ def _process_message_submit_failed(self, itask, event_time): | |||
| self.setup_event_handlers( | |||
| itask, self.EVENT_SUBMIT_RETRY, | |||
| "job %s, %s" % (self.EVENT_SUBMIT_FAILED, delay_msg)) | |||
| self.job_pool.set_job_state(job_d, TASK_STATUS_SUBMIT_RETRYING) | |||
There was a problem hiding this comment.
The submit retrying status is a task status, not a job status.
matthewrmshin
commented
Aug 28, 2019
| self.suite_db_mgr.put_update_task_jobs(itask, { | ||
| "time_run": itask.summary['started_time_string']}) | ||
| if itask.state.reset(TASK_STATUS_RUNNING): | ||
| self.setup_event_handlers(itask, 'started', 'job started') |
There was a problem hiding this comment.
The start time is now set before we set up the started event handler.
matthewrmshin
commented
Aug 28, 2019
| @@ -680,6 +680,7 @@ def _process_message_failed(self, itask, event_time, message): | |||
| itask.set_summary_time('finished', event_time) | |||
| job_d = get_task_job_id(itask.point, itask.tdef.name, itask.submit_num) | |||
| self.job_pool.set_job_time(job_d, 'finished', event_time) | |||
| self.job_pool.set_job_state(job_d, TASK_STATUS_FAILED) | |||
There was a problem hiding this comment.
Job status is failed, regardless of task retrying.
matthewrmshin
force-pushed
the
fix-task-event-start-time
branch
from
2b696fb
to
56e52ac
Compare
dwsutherland
requested changes
Aug 29, 2019
There was a problem hiding this comment.
Looks good; in the job_pool.py could you remove TASK_STATUS_SUBMIT_RETRYING from the import and job states list:
JOB_STATUSES_ALL = [
TASK_STATUS_READY,
TASK_STATUS_SUBMITTED,
TASK_STATUS_SUBMIT_FAILED,
TASK_STATUS_SUBMIT_RETRYING,
TASK_STATUS_RUNNING,
TASK_STATUS_SUCCEEDED,
TASK_STATUS_FAILED,
]
If you think ready state doesn't make sense (as I thought of it as "job file ready"), perhaps we could address that also? (although maybe the new submitting state would be appropriate in the related PR)
The `start_time` is now available as a template key for task event handler. Also rearranged a few statements (for recording the job status) in `cylc.flow.task_events_mgr` for consistency.
matthewrmshin
force-pushed
the
fix-task-event-start-time
branch
from
56e52ac
to
5cf0613
Compare
|
@dwsutherland Done what you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
start_timeis now available as a template key for task event handler.Also rearranged a few statements (for recording the job status) in
cylc.flow.task_events_mgrfor consistency.These changes close #2757, (see #2757 (comment)).
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.