Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hub url config to globalcfg #5733

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Sep 18, 2023

Closes cylc/cylc-uiserver#238

Added hub url to global config.
This is used by cylc-ui-server (see cylc/cylc-uiserver#507) for routing users to the hub on execution of
cylc gui

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present). NA
  • Tests are included (or explain why tests are not needed). NA - nothing that can be tested
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.NA

@markgrahamdawson markgrahamdawson marked this pull request as ready for review September 18, 2023 10:27
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@markgrahamdawson markgrahamdawson self-assigned this Sep 18, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.3.0 milestone Sep 18, 2023
@oliver-sanders
Copy link
Member

oliver-sanders commented Sep 20, 2023

(closed and re-opened to pick up the CI fix, tests should pass now)

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com>
@wxtim wxtim merged commit a06688a into cylc:master Sep 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hub: the gui command should open the hub URL when configured
3 participants