Feature.skip mode #6039
Open
Feature.skip mode #6039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feature.skip_mode
branch
2 times, most recently
from
b43d296
to
d26c315
Compare
wxtim
force-pushed
the
feature.skip_mode
branch
from
d378e3a
to
e9c2e25
Compare
wxtim
requested review from
oliver-sanders,
markgrahamdawson and
MetRonnie
and removed request for
markgrahamdawson
MetRonnie
reviewed
Apr 23, 2024
wxtim
force-pushed
the
feature.skip_mode
branch
4 times, most recently
from
3d002ee
to
dd0a9fc
Compare
MetRonnie
reviewed
May 8, 2024
wxtim
force-pushed
the
feature.skip_mode
branch
3 times, most recently
from
0d42eab
to
c37ef72
Compare
wxtim
force-pushed
the
feature.skip_mode
branch
2 times, most recently
from
3839a8a
to
d7ee653
Compare
MetRonnie
reviewed
May 20, 2024
Comment on lines
+354
to
+355
| # blacklist Run Modes: | ||
| not_equals(*RunMode.MODES), |
There was a problem hiding this comment.
Shouldn't this just be RunMode.SKIP?
There was a problem hiding this comment.
I'm really not sure that it's a good idea to have any of the RunMode strings as custom outputs. But you are right, it might concievably break someone's existing practice.
MetRonnie
reviewed
May 24, 2024
MetRonnie
reviewed
May 24, 2024
MetRonnie
reviewed
May 29, 2024
* Add `[runtime][<namespace>]run mode` and `[runtime][<namespace>][skip]`. * Spin run mode functionality into separate modules. * Run sim mode check with every main loop - we don't know if any tasks are in sim mode from the scheduler, but it doesn't cost much to check if none are. * Implemented separate job "submission" pathway switching. * Implemented skip mode, including output control logic. * Add a linter and a validation check for tasks in nonlive modes, and for combinations of outputs * Enabled setting outputs as if task ran in skip mode using `cylc set --out skip`. * Testing for the above.
remove ghost mode terminology added run_mode as a field to be used in the gui Response to review: Remove unwanted args to skip mode
MetRonnie
reviewed
May 29, 2024
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5641
Skip Mode Proposal Doc
This branch includes (marked against skip mode proposal):
[runtime][<namespace>]run mode.a. Broadcast can change
run modefor future task job submissions.b. Cylc Validate and lint will warn about the setting not being live.
run mode = skiprespectsis_heldflag.There are two extensions, which I haven't dealt with yet, because I want to ensure that the basic functionality works, and move to the substantial documentation PR which need follow this.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users