Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtrigger validation: log traceback for unexpected user validation errors #6160

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jun 19, 2024

Small change with no associated issue

Can test by installing a custom xtrigger module with a validate function that raises a RuntimeError, for example

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are not needed
  • Changelog entry not needed as minor
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small could be better Not exactly a bug, but not ideal. labels Jun 19, 2024
@MetRonnie MetRonnie added this to the 8.3.1 milestone Jun 19, 2024
@MetRonnie MetRonnie self-assigned this Jun 19, 2024
@oliver-sanders
Copy link
Member

(LGTM, haven't tested)

@MetRonnie MetRonnie requested a review from wxtim June 19, 2024 14:30
@wxtim wxtim merged commit 62527e0 into cylc:8.3.x Jun 20, 2024
27 checks passed
@MetRonnie MetRonnie deleted the xtrig-validate branch June 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants