Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin fails if CLI opts given, but workflow not a Rose suite. #118

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Plugin fails if CLI opts given, but workflow not a Rose suite. #118

merged 4 commits into from
Mar 21, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Mar 14, 2022 •
edited

Closes #117

@dpmatthews - I'm tagging you here, so you get a message that I've put a PR up, but not list you as a reviewer.

@wxtim wxtim added this to the 1.0.2 milestone Mar 14, 2022
@wxtim wxtim self-assigned this Mar 14, 2022
@wxtim wxtim requested a review from datamel March 14, 2022 13:16
@wxtim wxtim force-pushed the 117_no_Rose_CLI_if_no_Rose branch from 2319cb5 to cb4c333 Compare March 14, 2022 16:23
@wxtim wxtim marked this pull request as draft March 16, 2022 08:20
@wxtim
Copy link
Member Author

wxtim commented Mar 16, 2022

I've accidentally discovered that this is broken - converted to draft until I've fixed.

@wxtim wxtim marked this pull request as ready for review March 16, 2022 08:28
@wxtim
Copy link
Member Author

wxtim commented Mar 16, 2022

I've accidentally discovered that this is broken - converted to draft until I've fixed.

And now fixèd.

datamel
datamel reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code read, tests run locally and manually tested - no problems found. Currently waiting for the cylc and rose test batteries to run to double check for any breakages.

@wxtim wxtim requested a review from datamel March 17, 2022 13:24
datamel
datamel approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working well. Thanks @wxtim.

@wxtim wxtim requested a review from MetRonnie March 18, 2022 11:20
MetRonnie
MetRonnie reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of suggestions

CHANGES.md Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
cylc/rose/entry_points.py Outdated Show resolved Hide resolved
@wxtim @MetRonnie
Apply suggestions from code review
eb12029 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie March 18, 2022 14:26
@wxtim wxtim merged commit 0d86087 into cylc:master Mar 21, 2022
@wxtim wxtim deleted the 117_no_Rose_CLI_if_no_Rose branch March 21, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Fail if rose options used in non-rose workflow
3 participants
@wxtim @datamel @MetRonnie