Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain the expand/collapse states #391

Closed
kinow opened this issue Jan 30, 2020 · 1 comment
Closed

Maintain the expand/collapse states #391

kinow opened this issue Jan 30, 2020 · 1 comment

Comments

@kinow
Copy link
Member

kinow commented Jan 30, 2020

Describe exactly what you would like to see in an upcoming release

See the last paragraph in this comment from the infinite-tree/virtual-scroller PR: #345 (comment)

The state that used to be in a Vue component, but after #345, it will be in the data from the Vuex store. So there will be a default state for expand/collapse. Users can change that state by expanding or collapsing nodes.

But once the Vuex data store gets new data for the tree, it will re-create all the nodes, resetting the expand/collapse. Which is quite annoying.

After we have deltas in the UI Server, and can selectively update the nodes, we should be able to choose how to update the node state. Including — but not only — expanded/collapsed.

Additional context

Pull requests welcome!

@kinow
Copy link
Member Author

kinow commented Aug 20, 2020

Not an issue any more, as we have the working tree now with deltas only. Closing.

@kinow kinow closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant