Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: bump traitlets version #205

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 14, 2021

Jupyterhub brings in traitlets v4, our usage requires v5.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • Created an issue Bump traitlets version to >5. conda-forge/cylc-uiserver-feedstock#13

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest removing line 47 as it's become misleading

cylc-uiserver/setup.py

Lines 45 to 47 in 9685dd4

# NB: no graphene version specified; we only make light use of it in our own
# code, so graphene-tornado's transitive version should do.
# Same for traitlets via jupyterhub transitive deps.

@kinow
Copy link
Member

kinow commented Apr 14, 2021

Leaving open so @oliver-sanders can take a look at Ronnie's comment above.

@MetRonnie MetRonnie merged commit 01a173b into cylc:master Apr 15, 2021
@oliver-sanders oliver-sanders deleted the traitlets-dep branch April 15, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants