Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterHub 1.4 #216

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented May 6, 2021

This is a small change with no associated Issue.

Was having a look at the code and comparing with a checked out jupyterhub when I realized the latest tag (1.4.0) didn't match the version installed with pip.

Looks like they released it some time ago and we didn't update it.

JupyterHub 1.4 is a small release, with several enhancements, bug fixes, and new configuration options.

There are no database schema changes requiring migration from 1.3 to 1.4.

1.4 is also the first version to start publishing docker images for arm64.

In particular, OAuth tokens stored in user cookies, used for accessing single-user servers and hub-authenticated services, have changed their expiration from one hour to the expiry of the cookie in which they are stored (default: two weeks). This is now also configurable via JupyterHub.oauth_token_expires_in.

The result is that it should be much less likely for auth tokens stored in cookies to expire during the lifetime of a server.

Tested with five just now, found no errors 馃憤

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • Created an issue at cylc-uiserver conda-forge repository with version changes (if you changed dependencies in setup.py, see recipe/meta.yaml).

@kinow
Copy link
Member Author

kinow commented May 6, 2021

Will let CI running, and tomorrow if the tests passed will create the Conda issue or PR

@kinow
Copy link
Member Author

kinow commented May 6, 2021

@kinow kinow self-assigned this May 7, 2021
@kinow kinow added this to the cylc-uiserver 0.5.0 milestone May 7, 2021
@kinow kinow marked this pull request as ready for review May 7, 2021 02:08
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • start/stop hub
  • start/stop UIS via hub
  • logout/login
  • interacting with workflows

All appears fine, and test here passed 馃憤

@dwsutherland dwsutherland merged commit 993c1c7 into cylc:master May 11, 2021
@kinow kinow deleted the update-jupyterhub branch May 11, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants