Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter server #230
Jupyter server #230
Changes from 25 commits
e017edc
2dffb0d
449635b
e0631d0
a2bcfe8
7fa2f97
b2fb384
d3bfa88
da35266
fb88a33
e9f3ac9
49b096a
a521675
b73c6c3
5166b0b
eb30dc0
75160b2
e19717a
c1916f7
edf3fa1
1ec12e5
cd5e9c4
aa6a095
3b0b51b
8b0c544
72e05c5
5da6044
4c63763
acc20b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cylc.org/ currently forwards to https://niwa.co.nz/
I'm guessing this will be fixed by production time but thought I'd flag it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @hjoliver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's changed recently it used to redirect to GH pages, yikes!
Hmmm, I've seen this error before, I think my rebase of the cylc-ui branch might not have been fully successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Jupyter Server application, or a Jupyter web Application? I'm reading their docs, from what I understood, Jupyter Server is the utility code for creating applications or extensions. Applications being complete web applications that use the Jupyter Server, and Extensions only extend the REST API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, so looks like everything is an extension, but there's a special
ExtensionApp
that makes an extension that behaves like the old applications (like notebook, and current UI Server I think?). So everything is an extension? ๐There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there's some similar but different terminology here which makes things confusing.
The Cylc UI Server (as of this PR) is a "Jupyter Server extension applicaiton".
Extension applications can:
Jupyter server also offers non-configurable extensions (ones which aren't applications), these are cruder.
This page helps show the difference - https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oliver-sanders !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess it's an extension then, I thought it was an application ๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If splitting hairs it is technically an "extension application"!
From the users perspective the difference between an "extension" and an "extension application" is invisible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks @oliver-sanders ! It was more so I knew the correct term in case I needed to report an issue upstream, or talk to someone else about Jupyter Server. But extension application is quite a mouthful, I'll probably just use jupyter server, or jupyter server app, or whichever my ๐ง picks first. Leaving unresolved in case others are interested in this answer too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pulls in the
jupyter_server
testing framework.